maskit commented on PR #9931: URL: https://github.com/apache/trafficserver/pull/9931#issuecomment-1613872205
I found the related discussion about this variable. Seems like there **was** a lifetime issue and the type **was** shared_ptr on the first proposal. Maybe we don't have a reason not to use std:string now. https://github.com/apache/trafficserver/pull/6108#pullrequestreview-310186898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
