JosiahWI commented on code in PR #9967:
URL: https://github.com/apache/trafficserver/pull/9967#discussion_r1254862557
##########
tests/gold_tests/pluginTest/TSVConnFd/CMakeLists.txt:
##########
@@ -15,9 +15,12 @@
#
#######################
-add_library(TSVConnFd SHARED TSVConnFd.cc)
+add_library(TSVConnFd MODULE TSVConnFd.cc)
set_target_properties(TSVConnFd PROPERTIES
LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/.libs"
PREFIX ""
Review Comment:
Duplication: there's no need to set this twice. Could we remove one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
