JosiahWI commented on code in PR #10033: URL: https://github.com/apache/trafficserver/pull/10033#discussion_r1262970506
########## CMakeLists.txt: ########## @@ -48,6 +48,7 @@ execute_process(COMMAND uname -n OUTPUT_VARIABLE BUILD_MACHINE OUTPUT_STRIP_TRAI # Options option(BUILD_REGRESSION_TESTING "Build regression tests (default ON)" ON) +option(BUILD_EXPERIMENTAL_PLUGINS "Build the experimental plugins (default OFF)") Review Comment: Extra spaces between arguments. ########## plugins/experimental/traffic_dump/CMakeLists.txt: ########## @@ -0,0 +1,22 @@ +####################### +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license +# agreements. See the NOTICE file distributed with this work for additional information regarding +# copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed under the License +# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +# or implied. See the License for the specific language governing permissions and limitations under +# the License. +# +####################### + +add_atsplugin(traffic_dump + json_utils.cc + session_data.cc + traffic_dump.cc + transaction_data.cc) Review Comment: Closing ) should be on separate line and unindented. ########## plugins/experimental/traffic_dump/CMakeLists.txt: ########## @@ -0,0 +1,22 @@ +####################### +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license +# agreements. See the NOTICE file distributed with this work for additional information regarding +# copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed under the License +# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +# or implied. See the License for the specific language governing permissions and limitations under +# the License. +# +####################### + +add_atsplugin(traffic_dump Review Comment: This depends on libswoc, the SSL library, and the ATS include path. ```cmake target_include_directories(traffic_dump PRIVATE "${PROJECT_SOURCE_DIR}/include") target_link_libraries(traffic_dump PRIVATE libswoc ${OPENSSL_SSL_LIBRARY} ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
