bneradt commented on code in PR #10037: URL: https://github.com/apache/trafficserver/pull/10037#discussion_r1263854094
########## plugins/experimental/cookie_remap/CMakeLists.txt: ########## @@ -0,0 +1,50 @@ +####################### +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license +# agreements. See the NOTICE file distributed with this work for additional information regarding +# copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed under the License +# is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +# or implied. See the License for the specific language governing permissions and limitations under +# the License. +# +####################### + +project(cookie_remap) + +add_atsplugin(cookie_remap + cookie_remap.cc + cookiejar.cc + strip.cc +) + +target_include_directories(cookie_remap PRIVATE "${PROJECT_SOURCE_DIR}/include") + +target_link_libraries(cookie_remap + PRIVATE + "${YAMLCPP_INCLUDE_DIR}" Review Comment: Good catch. I looked for the target for yamlcpp and with my grep I found that and put that in without looking carefully enough at it. In any case, I moved this to the target_include_directories call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
