bneradt commented on code in PR #10050: URL: https://github.com/apache/trafficserver/pull/10050#discussion_r1264560173
########## CMakeLists.txt: ########## @@ -335,6 +335,13 @@ if (OPENSSL_FOUND) endif(OPENSSL_FOUND) add_subdirectory(lib) + +# Keep this after lib because lib is made up of third party libraries, so if +# there are warnings, we can't do anything about it. +add_compile_options(-pipe -Wall -Wextra -Werror -Wno-unused-parameter -Wno-format-truncation -Wno-cast-function-type -Wno-stringop-overflow) +add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Wno-noexcept-type>) +add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Wsuggest-override>) Review Comment: I could not figure out how to add two options to a generator like this without calling add_compile_options twice. I tried a variety of quoting permutations, but nothing worked. If someone else can figure it out, I'll pull it in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
