maskit commented on code in PR #10035:
URL: https://github.com/apache/trafficserver/pull/10035#discussion_r1265687584
##########
iocore/net/EventIO.h:
##########
@@ -97,11 +74,6 @@ struct EventIO {
@param events a mask of flags (for details `man epoll_ctl`)
@return int the number of events created, -1 is error
*/
- int start(EventLoop l, DNSConnection *vc, int events);
- int start(EventLoop l, NetAccept *vc, int events);
- int start(EventLoop l, NetEvent *ne, int events);
- int start(EventLoop l, UnixUDPConnection *vc, int events);
- int start(EventLoop l, int fd, NetEvent *ne, int events);
int start_common(EventLoop l, int fd, int events);
Review Comment:
Looks like we can make `start_common` a protected member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
