SolidWallOfCode commented on code in PR #10069:
URL: https://github.com/apache/trafficserver/pull/10069#discussion_r1275412674


##########
proxy/http/HttpConnectionCount.h:
##########
@@ -420,9 +420,9 @@ OutboundConnTrack::Linkage::equal(key_type lhs, key_type 
rhs)
 
 Action *register_ShowConnectionCount(Continuation *, HTTPHdr *);
 
-namespace ts
+namespace swoc

Review Comment:
   I haven't had much luck with that. I've tried to avoid using `std` but 
frequently it doesn't compile due to not found or ambiguity. I think one issue 
is if one is an overload and the other a templated overload, because the first 
"matches" it doesn't check the better match with the template.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to