ywkaras commented on code in PR #10106: URL: https://github.com/apache/trafficserver/pull/10106#discussion_r1276796313
########## doc/developer-guide/internal-libraries/MemArena.en.rst: ########## @@ -76,14 +76,14 @@ to not be an issue, or there must be a provision for some sort of garbage collec Generally |MemArena| is not as useful for classes that allocate their own internal memory (such as :code:`std::string` or :code:`std::vector`), which includes most container classes. One -container class that can be easily used is :class:`IntrusiveDList` because the links are in the +container class that can be easily used is :code:`swoc::IntrusiveDList` because the links are in the instance and therefore also in the arena. Objects created in the arena must not have :code:`delete` called on them as this will corrupt memory, usually leading to an immediate crash. The memory for the instance will be released when the arena is destroyed. The destructor can be called if needed but in general if a destructor is needed it is probably not a class that should be constructed in the arena. Looking at -:class:`IntrusiveDList` again for an example, if this is used to link objects in the arena, there is +:code`:`swoc::IntrusiveDList` again for an example, if this is used to link objects in the arena, there is Review Comment: The change doesn' t look any better to me: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/2472/Sphinx_20Docs/developer-guide/internal-libraries/MemArena.en.html#memarena . But anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
