JosiahWI opened a new pull request, #10114: URL: https://github.com/apache/trafficserver/pull/10114
This is the first of three parts of a refactoring to break out FeatureAPIHooks, making it possible to unit test hook callbacks. This moves the implementation of INKAPIInternal from InkAPI.cc to InkAPIInternal.cc, still in the traffic_server directory. I wrapped it in a new library, inkcont, as a convenient way to document its dependencies and link it into unit tests. This was by no means an easy refactor, and the result seems far from perfect. I would really appreciate feedback. The biggest roadblock was that parts of this proxy that this depends on also depend on `HostStatus`. This particular arrangement happens to work for unit testing so far, I think because the API hooks don't use any of those functions and thus the linker doesn't look for their definitions. I tried to move the source file to `tsapi` instead, but could not get it to compile without `HostStatus`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
