traeak commented on code in PR #10117:
URL: https://github.com/apache/trafficserver/pull/10117#discussion_r1280851631
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -1067,24 +1067,36 @@ mptcp
Control the scope of server session re-use if it is enabled by
:ts:cv:`proxy.config.http.server_session_sharing.match`. Valid values are:
- ========== =================================================================
- Value Description
- ========== =================================================================
- ``global`` Re-use sessions from a global pool of all server sessions.
- ``thread`` Re-use sessions from a per-thread pool.
- ``hybrid`` Try to work as a global pool, but release server sessions to the
- per-thread pool if there is lock contention on the global pool.
- ========== =================================================================
-
-
- Setting :ts:cv:`proxy.config.http.server_session_sharing.pool` to global
can reduce
- the number of connections to origin for some traffic loads. However, if
many
- execute threads are active, the thread contention on the global pool can
reduce the
- lifetime of connections to origin and reduce effective origin connection
reuse.
-
- For a hybrid pool, the operation starts as the global pool, but sessons are
returned
- to the local thread pool if the global pool lock is not acquired rather
than just
- closing the origin connection as is the case in standard global mode.
+ ================= ==========================================================
+ Value Description
+ ================= ==========================================================
+ ``global`` Re-use sessions from a global pool of all server sessions.
+ ``thread`` Re-use sessions from a per-thread pool.
+ ``hybrid`` Try to work as a global pool, but release server sessions
+ to the per-thread pool if there is lock contention on the
+ global pool.
+ ``global_locked`` Similar to global, except that the session pool is
+ managed by a blocking mutex.
+ ================= ==========================================================
+
+
+ Setting :ts:cv:`proxy.config.http.server_session_sharing.pool`
+ to global can reduce the number of connections to origin for some
+ traffic loads. However, if many execute threads are active, the thread
+ contention on the global pool can reduce the lifetime of connections
+ to origin and reduce effective origin connection reuse.
+
+ For a hybrid pool, the operation starts as the global pool, but sessons
+ are returned to the local thread pool if the global pool lock is not
+ acquired rather than just closing the origin connection as is the
+ case in standard global mode.
+
+ For a ``global_locked`` pool connections are managed by a blocking
+ mutex instead of the normal try mutex. Under extreme transaction
+ loads the connection pool starvation may result in most transactions
+ bypassing the connection pool resulting in runaway upstream
Review Comment:
retrying the lock would result in even further pool starvation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]