JosiahWI commented on code in PR #10191: URL: https://github.com/apache/trafficserver/pull/10191#discussion_r1296311795
########## example/cripts/CMakeLists.txt: ########## @@ -0,0 +1,51 @@ +# ############################################################################## +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ############################################################################## + +# Todo: It'd be useful to build all Cripts that are put into this directory, +# using GLOB etc. like this: +# file(GLOB CRIPTS_EXAMPLES ${PROJECT_SOURCE_DIR}/example/cripts/*.cc) +# +# foreach(EXA ${CRIPTS_EXAMPLES}) +# get_filename_component(EXA ${EXA} NAME_WLE) +# .... +# endforeach() + +add_atsplugin(cripts_example1 example1.cc) + +target_include_directories(cripts_example1 PRIVATE "${PROJECT_SOURCE_DIR}/include") +target_link_libraries(cripts_example1 PRIVATE ts::cripts) + +# This is a hack, but useful to run clang-tidy across all of Cripts +# Todo: why is this not working?? +#find_package(fmt 8.1 REQUIRED) +#$<TARGET_PROPERTY:fmt::fmt,INCLUDE_DIRECTORIES> + Review Comment: What is it supposed to do? First thing that stands out is that the generator expression probably needs to go inside some other command? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
