SolidWallOfCode commented on code in PR #10234:
URL: https://github.com/apache/trafficserver/pull/10234#discussion_r1300720738


##########
proxy/http/HttpTransact.cc:
##########
@@ -1632,8 +1628,7 @@ HttpTransact::HandleRequest(State *s)
   // Added to skip the dns if the document is in the cache.
   // DNS is requested before cache lookup only if there are rules in 
cache.config , parent.config or
   // if the newly added variable doc_in_cache_skip_dns is not enabled
-  if (s->dns_info.lookup_name[0] <= '9' && s->dns_info.lookup_name[0] >= '0' &&
-      (!s->state_machine->enable_redirection || 
!s->redirect_info.redirect_in_process) &&
+  if (ats_is_ip(&s->server_info.name_addr) && 
(!s->state_machine->enable_redirection || 
!s->redirect_info.redirect_in_process) &&

Review Comment:
   `s->server_info.name_addr.is_valid()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to