SolidWallOfCode commented on code in PR #10286:
URL: https://github.com/apache/trafficserver/pull/10286#discussion_r1308015368
##########
iocore/cache/Cache.cc:
##########
@@ -2193,6 +2193,11 @@ CacheVC::handleReadDone(int event, Event *e)
}
goto Ldone;
}
+ if (DISK_BAD(vol->disk)) {
+ io.aio_result = -1;
+ Warning("Canceling cache read: disk is bad.");
Review Comment:
Can we change this to use `vol->hash_text.get()` to indicate which disk is
bad?
`Warning("Canceling cache read: disk %s is bad.", vol->hash_text.get());`
See the bad read debug note above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
