bneradt commented on code in PR #10306:
URL: https://github.com/apache/trafficserver/pull/10306#discussion_r1315110984
##########
iocore/net/OCSPStapling.cc:
##########
@@ -1097,7 +1204,21 @@ stapling_refresh_response(certinfo *cinf,
TS_OCSP_RESPONSE **prsp)
goto err;
}
- *prsp = query_responder(cinf->uri, cinf->user_agent, req,
SSLConfigParams::ssl_ocsp_request_timeout);
+ if (SSLConfigParams::ssl_ocsp_request_mode) { // True: GET, False: POST
Review Comment:
This also would be clearer as `ssl_ocsp_prefer_get` or some such. Otherwise
maybe create an enum and switch on that value?
```cpp
bool use_get = false;
switch(SSLConfigParams::ssl_ocsp_request_mode) {
case USE_GET:
use_get = true;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
