traeak commented on code in PR #10285:
URL: https://github.com/apache/trafficserver/pull/10285#discussion_r1309240260
##########
plugins/experimental/slice/server.cc:
##########
@@ -668,8 +668,10 @@ handle_server_resp(TSCont contp, TSEvent event, Data
*const data)
data->m_blocknum = firstblock;
}
- // continue processing blocks?
- if (data->m_req_range.blockIsInside(data->m_config->m_blockbytes,
data->m_blocknum)) {
+ // continue processing blocks if more requests need to be made
+ // HEAD requests only has one slice block
+ if (data->m_req_range.blockIsInside(data->m_config->m_blockbytes,
data->m_blocknum) &&
+ !(data->m_config->m_method_type == TS_HTTP_METHOD_HEAD)) {
Review Comment:
i personally would prefer the != rather than the !(stuff == other stuff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
