zwoop commented on code in PR #10324:
URL: https://github.com/apache/trafficserver/pull/10324#discussion_r1318742008
##########
src/traffic_server/InkAPI.cc:
##########
@@ -9132,6 +9132,16 @@ tsapi::c::TSVConnSslConnectionGet(TSVConn sslp)
return ssl;
}
+int
+tsapi::c::TSVConnFdGet(TSVConn vconnp)
+{
Review Comment:
It kinda feels that we should do the normal assertion on the vconnp here,
rather than checking the nullptr after the casting. Like the common pattern is
```
sdk_assert(sdk_sanity_check_null_ptr((void *)vconnp) == TS_SUCCESS);
```
I guess I'm fine checking the vconnp explicitly as well, but probably should
be done before the cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
