shinrich commented on code in PR #9574:
URL: https://github.com/apache/trafficserver/pull/9574#discussion_r1321995046
##########
iocore/net/SSLNetVConnection.cc:
##########
@@ -587,6 +587,10 @@ SSLNetVConnection::net_read_io(NetHandler *nh, EThread
*lthread)
if (!getSSLHandShakeComplete()) {
int err = 0;
+ // May get into logic that will clean up the current VC
+ // Increment the recursion to delay do_io_close cleaup.
+ this->recursion++;
Review Comment:
Adding this recursion bump, other use after free ASAN error would trigger on
the later if (this->handshakeReader) check because with addition of the
_migrateSsl, the SSLNetVC object (this) may have been deleted.
By incrementing recursion and adding test_inline_close() on return, we
ensure that the deletion of this does not occur until the end of the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
