sharkleash commented on code in PR #10098:
URL: https://github.com/apache/trafficserver/pull/10098#discussion_r1330527593
##########
iocore/net/UnixNetAccept.cc:
##########
@@ -369,7 +384,15 @@ NetAccept::do_blocking_accept(EThread *t)
// Assign NetHandler->mutex to NetVC
vc->mutex = h->mutex;
localt->schedule_imm(vc);
- } while (loop);
+ } while (count <= additional_accepts);
+
+ // for dedicated blocking accept threads, if we reach the maximum additional
accepts
Review Comment:
I was hoping you'd ask about this part 😃 I was pretty sure this wasn't
necessary because blocking accept threads don't run into the same starvation
problem., but I wanted some confirmation. Will remove.
##########
iocore/net/UnixNetAccept.cc:
##########
@@ -369,7 +384,15 @@ NetAccept::do_blocking_accept(EThread *t)
// Assign NetHandler->mutex to NetVC
vc->mutex = h->mutex;
localt->schedule_imm(vc);
- } while (loop);
+ } while (count <= additional_accepts);
+
+ // for dedicated blocking accept threads, if we reach the maximum additional
accepts
Review Comment:
I was hoping you'd ask about this part 😃 I was pretty sure this wasn't
necessary because blocking accept threads don't run into the same starvation
problem., but I wanted some confirmation. Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
