bryancall commented on code in PR #10407: URL: https://github.com/apache/trafficserver/pull/10407#discussion_r1336409664
########## include/tscore/ink_memory.h: ########## @@ -49,7 +49,11 @@ #endif #if TS_HAS_JEMALLOC +#if __has_include(<jemalloc/jemalloc.h>) #include <jemalloc/jemalloc.h> +#else +#include <jemalloc.h> Review Comment: Ee only need to have `#include <jemalloc.h>` in the code for compiling with `cmake`. The include directory detection add in the subdir `jemalloc`. However, with autotools we need to have the `#include <jemalloc/jemalloc.h>` ########## include/tscore/ink_memory.h: ########## @@ -49,7 +49,11 @@ #endif #if TS_HAS_JEMALLOC +#if __has_include(<jemalloc/jemalloc.h>) #include <jemalloc/jemalloc.h> +#else +#include <jemalloc.h> Review Comment: We only need to have `#include <jemalloc.h>` in the code for compiling with `cmake`. The include directory detection add in the subdir `jemalloc`. However, with autotools we need to have the `#include <jemalloc/jemalloc.h>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
