cmcfarlen commented on PR #10577: URL: https://github.com/apache/trafficserver/pull/10577#issuecomment-1758385923
> If stubs are clearly a bad thing in unit tests, why are tools like gMock widely used? Mocking is about changing behavior of a code dependency in order to facilitate testing other aspects of a system. This PR removes functionality from tests that are very useful for creating and troubleshooting tests. This is nowhere near the same thing. IMO stubs(and mocking) are bad if they are incurred incidental complexity to writing a test. Not to mention the code duplication in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
