JosiahWI commented on code in PR #10597: URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357507644
########## proxy/http/HttpTransactCache.cc: ########## @@ -29,6 +29,10 @@ #include <ctime> #include "HTTP.h" #include "HttpCompat.h" + +// inkcache +#include "P_Cache.h" Review Comment: Otherwise I could include the specific headers it needs. `P_Cache.h` doesn't contain any declarations - it just brings in all the other Cache headers. ########## proxy/http/HttpTransactCache.cc: ########## @@ -29,6 +29,10 @@ #include <ctime> #include "HTTP.h" #include "HttpCompat.h" + +// inkcache +#include "P_Cache.h" Review Comment: Otherwise I could include the specific headers it needs. `P_Cache.h` doesn't contain any declarations - it just brings in all the other Cache headers. Would that be preferable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
