masaori335 commented on code in PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#discussion_r1357588602
##########
proxy/http/PreWarmManager.h:
##########
@@ -312,6 +216,16 @@ class PreWarmQueue : public Continuation
class PreWarmManager
{
public:
+ PreWarmManager()
+ {
+ // We use the callback because it would introduce a circular dependency
+ // for SNIConfig to explicitly call prewarmManager.reconfigure().
+ // Because prewarmManager is global there's not a good place to set
+ // this, but as long as there's only one instance of this class
+ // there should not be an issue.
+ SNIConfig::set_on_reconfigure_callback([this]() { this->reconfigure(); });
Review Comment:
Nice idea to get rid of the cyclic dependency 👍
##########
proxy/http/PreWarmManager.h:
##########
@@ -312,6 +216,16 @@ class PreWarmQueue : public Continuation
class PreWarmManager
{
public:
+ PreWarmManager()
+ {
+ // We use the callback because it would introduce a circular dependency
+ // for SNIConfig to explicitly call prewarmManager.reconfigure().
+ // Because prewarmManager is global there's not a good place to set
+ // this, but as long as there's only one instance of this class
+ // there should not be an issue.
+ SNIConfig::set_on_reconfigure_callback([this]() { this->reconfigure(); });
Review Comment:
Nice idea to get rid of the cyclic dependency 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
