cmcfarlen commented on code in PR #10601: URL: https://github.com/apache/trafficserver/pull/10601#discussion_r1358385088
########## iocore/cache/CacheVC.cc: ########## @@ -21,12 +21,17 @@ limitations under the License. */ +#include "I_Cache.h" #include "I_CacheDefs.h" #include "P_CacheDisk.h" #include "P_CacheHttp.h" +// #include "P_CacheHosting.h" Review Comment: delete this line. ########## iocore/cache/CacheVC.cc: ########## @@ -21,12 +21,17 @@ limitations under the License. */ +#include "I_Cache.h" #include "I_CacheDefs.h" #include "P_CacheDisk.h" #include "P_CacheHttp.h" +// #include "P_CacheHosting.h" #include "P_CacheInternal.h" #include "P_CacheVol.h" +// must be included after the others Review Comment: Should CacheVC.h include the required files itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
