JosiahWI commented on code in PR #10602: URL: https://github.com/apache/trafficserver/pull/10602#discussion_r1358420646
########## plugins/experimental/sslheaders/CMakeLists.txt: ########## @@ -16,7 +16,7 @@ ####################### add_library(sslhdr STATIC expand.cc util.cc) -target_link_libraries(sslhdr PRIVATE OpenSSL::SSL) +target_link_libraries(sslhdr PUBLIC OpenSSL::SSL) Review Comment: I think we should keep this `PRIVATE` and link `test_sslhdr` to `OpenSSL::SSL` instead. The missing headers are included directly by the test; it's not a transitive dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
