JosiahWI opened a new pull request, #10603: URL: https://github.com/apache/trafficserver/pull/10603
This extracts a subclass from `CacheVC` called `CacheEvacuateDocVC` and moves the logic for evacuating a doc to the new subclass. By having less code in it, `CacheVC` should be a little simpler. While doing the extraction, I also read through the logic and tried to clean up the logic flow a little bit. This last bit was risky, and I'm not confident we have enough test coverage to be sure it was done correctly. I did my best to double check my reasoning on every change, but please review carefully. The two dangerous refactorings I did are split into two commits. The first one should be the simplest and safest. It just extracts a method which returns a status boolean, and remembers to check that boolean to abort on failure. The second refactoring was more involved. I will copy the commit message, which explains the refactoring, for convenience. > This extracts some methods and attempts to make the logic flow more self-evident. Most importantly, it makes it obvious that the method locates a particular evacuation block to work with, and terminates after it finishes. The previous logic flow obscured this by putting all the operations on the block within the search loop body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
