cmcfarlen commented on PR #10612: URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764329718
IMO just setting CMAKE_CXX_STANDARD directly is less mysterious than a custom setting for the same. Also, we will have to maintain this one when we want to build with C++23 or whatever other wacky standard version code name compiler vendors come up with (C++2d perhaps?). Its also more inline with cmake's idiom of not setting compiler flags directly but letting that be done from outside at configuration time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
