duke8253 commented on code in PR #10673:
URL: https://github.com/apache/trafficserver/pull/10673#discussion_r1373354923
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -852,9 +852,14 @@ Http2ConnectionState::rcv_goaway_frame(const Http2Frame
&frame)
while (nbytes < frame.header().length) {
unsigned read_bytes = read_rcv_buffer(buf, sizeof(buf), nbytes, frame);
- if (!http2_parse_goaway(make_iovec(buf, read_bytes), goaway)) {
- return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_CONNECTION,
Http2ErrorCode::HTTP2_ERROR_PROTOCOL_ERROR,
- "goaway failed parse");
+ if (nbytes == HTTP2_GOAWAY_LEN) {
Review Comment:
Yeah, I think we can, but I'm not sure whether we plan on handling the
`Additional Debug Data` part in the future. I'm down for removing the loop all
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
