JosiahWI commented on code in PR #10720: URL: https://github.com/apache/trafficserver/pull/10720#discussion_r1381948219
########## plugins/experimental/maxmind_acl/CMakeLists.txt: ########## @@ -14,11 +14,16 @@ # the License. # ####################### +find_package(maxminddb QUIET) Review Comment: @traeak observed that `QUIET` silences the messages indicating the package was found. We probably don't want that. ```cmake find_package(maxminddb) ``` will keep the informational messages. We want to change this to an `auto_option` but we can change this and `stek_share` to use `auto_option` together in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
