SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383829121
##########
src/iocore/net/ConnectionTracker.cc:
##########
@@ -148,10 +163,31 @@ ConnectionTracker::config_init(GlobalConfig *global,
TxnConfig *txn)
_global_config = global; // remember this for later retrieval.
// Per transaction lookup must be done at call time
because it changes.
+ Enable_Config_Var(CONFIG_CLIENT_VAR_ALERT_DELAY,
&Config_Update_Conntrack_Client_Alert_Delay, global);
Enable_Config_Var(CONFIG_SERVER_VAR_MIN, &Config_Update_Conntrack_Min, txn);
Enable_Config_Var(CONFIG_SERVER_VAR_MAX, &Config_Update_Conntrack_Max, txn);
Enable_Config_Var(CONFIG_SERVER_VAR_MATCH, &Config_Update_Conntrack_Match,
txn);
- Enable_Config_Var(CONFIG_SERVER_VAR_ALERT_DELAY,
&Config_Update_Conntrack_Alert_Delay, global);
+ Enable_Config_Var(CONFIG_SERVER_VAR_ALERT_DELAY,
&Config_Update_Conntrack_Server_Alert_Delay, global);
+}
+
+ConnectionTracker::TxnState
+ConnectionTracker::obtain_inbound(IpEndpoint const &addr)
Review Comment:
Could this be unified by passing a `Direction` parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
