zwoop commented on code in PR #10694: URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384184194
########## include/proxy/http2/Http2ServerSession.h: ########## @@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public Http2CommonSession void increment_current_active_connections_stat() override { - Metrics::increment(http2_rsb.current_active_server_connection_count); + Metrics::Gauge::increment(http2_rsb.current_active_server_connection_count); Review Comment: I thought of that, and even asked @cmcfarlen , we both preferred the static. I can change it if we think it's better. It just reads better with the static IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org