zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384381660
##########
src/iocore/aio/test_AIO.cc:
##########
@@ -223,11 +223,11 @@ dump_summary()
auto &m = Metrics::getInstance();
- Metrics::IntType *completed =
m.lookup(m.lookup("proxy.process.io_uring.completed"));
- Metrics::IntType *submitted =
m.lookup(m.lookup("proxy.process.io_uring.submitted"));
+ Metrics::Counter::AtomicType *completed =
m.lookup(m.lookup("proxy.process.io_uring.completed"));
+ Metrics::Counter::AtomicType *submitted =
m.lookup(m.lookup("proxy.process.io_uring.submitted"));
- printf("submissions: %lu\n", Metrics::read(submitted));
- printf("completions: %lu\n", Metrics::read(completed));
+ printf("submissions: %lu\n", Metrics::Gauge::load(submitted));
Review Comment:
Yeh, not my code. I'm fairly certain we've agreed that you don't have to
rewrite everyones code to make something "better".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
