zwoop commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1384396585


##########
include/api/Metrics.h:
##########
@@ -45,23 +45,47 @@ class Metrics
 private:
   using self_type = Metrics;
 
+  class AtomicType
+  {
+    friend class Metrics;
+
+  public:
+    AtomicType()          = default;
+    virtual ~AtomicType() = default;

Review Comment:
   @ywkaras I added those static's, which allows us to eliminate the virtual. 
Let me know what you think, it's in the last commit that I lovingly made just 
for you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to