ywkaras commented on code in PR #10750:
URL: https://github.com/apache/trafficserver/pull/10750#discussion_r1386771919
##########
tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc:
##########
@@ -484,8 +484,8 @@ class Ramp_test : private Send_to_vconn
class _Send_recv : private Send_to_vconn, private Recv_from_vconn
{
public:
- _Send_recv(TSVConn vconn_, std::shared_ptr<File_deleter> f_del, int
n_groups_send, int n_group_bytes, bool allow_send_error,
- int n_bytes_recv)
+ _Send_recv(TSVConn vconn_, std::shared_ptr<File_deleter> const &f_del, int
n_groups_send, int n_group_bytes,
+ bool allow_send_error, int n_bytes_recv)
Review Comment:
Coverity is being a jerk, since inlining and copy elision should make either
of these the same in the object code. But anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
