ywkaras commented on code in PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#discussion_r1392769053
##########
plugins/experimental/uri_signing/unit_tests/CMakeLists.txt:
##########
@@ -26,8 +26,6 @@ add_executable(
${PROJECT_SOURCE_DIR}/match.cc
${PROJECT_SOURCE_DIR}/normalize.cc
${PROJECT_SOURCE_DIR}/parse.cc
- ${PROJECT_SOURCE_DIR}/timing.cc
- ${PROJECT_SOURCE_DIR}/uri_signing.cc
)
target_compile_definitions(uri_signing_test PRIVATE UNITTEST)
Review Comment:
Looks like the unit test stuff still needs some cleanup. The -D for the
unit test is URI_SIGNING_UNIT_TEST (
https://github.com/apache/trafficserver/blob/6e00344df420db067e2b3cddbe8a7a48b7559700/plugins/experimental/uri_signing/common.cc#L21
), not UNITTEST. But, since the test works, it looks like the code triggered
by URI_SIGNING_UNIT_TEST can just be deleted. But we could do all that in a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
