JosiahWI commented on code in PR #10780:
URL: https://github.com/apache/trafficserver/pull/10780#discussion_r1394627576


##########
lib/swoc/CMakeLists.txt:
##########
@@ -118,3 +118,6 @@ set_target_properties(
 )
 
 install(TARGETS libswoc PUBLIC_HEADER DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR}/swoc)
+
+add_library(libswoc::libswoc ALIAS libswoc-static)
+add_library(libswoc::libswoc ALIAS libswoc)

Review Comment:
   Whoa there. This looks problematic. 😄 



##########
lib/swoc/CMakeLists.txt:
##########
@@ -118,3 +118,6 @@ set_target_properties(
 )
 
 install(TARGETS libswoc PUBLIC_HEADER DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR}/swoc)
+
+add_library(libswoc::libswoc ALIAS libswoc-static)
+add_library(libswoc::libswoc ALIAS libswoc)

Review Comment:
   Whoa there. This looks problematic. 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to