bneradt commented on code in PR #10819:
URL: https://github.com/apache/trafficserver/pull/10819#discussion_r1397894062


##########
plugins/experimental/stek_share/stek_share.cc:
##########
@@ -422,7 +422,7 @@ stek_updater(void *arg)
   ::pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, nullptr);
   ::pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, nullptr);
 
-  Dbg(dbg_ctl, "Starting STEK updater thread: %lu", ::pthread_self());
+  Dbg(dbg_ctl, "Starting STEK updater thread");

Review Comment:
   I'll merge as is to alleviate the warning. If we want a more specific log 
message, I'd suggest implementing a separate function that returns an unsigned 
long from the variety of types. It can inspect `__APPLE__` and handle that and 
possibly other situations too (not sure offhand what freebsd does, for 
instance).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to