bneradt commented on code in PR #10811: URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1400780073
########## src/traffic_crashlog/backtrace.cc: ########## @@ -0,0 +1,178 @@ +#include "tscore/ink_config.h" Review Comment: Thank you for the heads up, @randall and @brbzull0. When I added cmake support to CI, I assumed that the rat target would have a non-zero return if the check failed. I updated the pipeline to check the output and fail if there were not 0 errors (as we did with autotools). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
