cmcfarlen commented on PR #10859: URL: https://github.com/apache/trafficserver/pull/10859#issuecomment-1830974410
This is the kind of config that IMO we should NOT have in the cmakelists.txt. What is provided will very often not be enough to get this to work (you will need to add paths and other linker flags as well). CMake has some guidelines for compiler config that falls outside of the common things that cmake has cross-compiler support for (i.e. build type, warnings as errors) which is basically let the user set flags and variable externally. There is also a full feature (toolchains) that is more appropriate for this sort of setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
