phongn commented on code in PR #10864: URL: https://github.com/apache/trafficserver/pull/10864#discussion_r1408711509
########## src/iocore/net/test_certlookup.cc: ########## @@ -234,7 +234,7 @@ main(int argc, const char **argv) ink_freelists_dump(stdout); // On Darwin, fail the tests if we have any memory leaks. Review Comment: I thought about it, but it's not actually wrong either (and `uname` returns `Darwin` on macOS). It's really just the preprocessor directives that should be changed. Also, a number of places look for the `Darwin` string as well for various purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
