cmcfarlen commented on code in PR #10867:
URL: https://github.com/apache/trafficserver/pull/10867#discussion_r1412577144


##########
src/tscore/ink_mutex.cc:
##########
@@ -35,7 +35,7 @@ class x_pthread_mutexattr_t
   x_pthread_mutexattr_t()
   {
     pthread_mutexattr_init(&attr);
-#ifndef POSIX_THREAD_10031c
+#if HAVE_PTHREAD_MUTEXATTR_SETPSHARED
     pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);

Review Comment:
   I do not think we should be setting mutexes pshared at all.  I don't think 
it matters anyways unless the mutexes are in shared memory regions.  I think we 
could just delete this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to