SolidWallOfCode commented on PR #10941: URL: https://github.com/apache/trafficserver/pull/10941#issuecomment-1859254141
Still parsing the code, I thought this wasn't doing a heap allocation so I closed the PR, but in fact it does. `url_string_get` takes a `HdrHeap*` which, if `nullptr`, avoids a heap allocation. However, `HttpHdr::url_string_get` always passes in `HttpHdr::m_heap` therefore this call always results in the URL being on the heap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
