traeak commented on code in PR #10942:
URL: https://github.com/apache/trafficserver/pull/10942#discussion_r1430547497


##########
plugins/experimental/rate_limit/limiter.h:
##########
@@ -117,12 +117,15 @@ template <class T> class RateLimiter
     memset(_metrics, 0, sizeof(_metrics));
 
     std::string metric_prefix = prefix;

Review Comment:
   I suspect it's due to the std::string/std::string_view handling (circular 
dependency hell) where the compiler might get confused trying to figure out how 
to deal with the first argument in the following (for example):
   ```
   result += "/" + somestringfunc();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to