ywkaras commented on code in PR #10944:
URL: https://github.com/apache/trafficserver/pull/10944#discussion_r1430901280
##########
lib/swoc/include/swoc/TextView.h:
##########
@@ -1057,15 +1057,15 @@ uintmax_t svtou(TextView src, TextView *parsed =
nullptr, int base = 0);
template <int RADIX>
uintmax_t
svto_radix(TextView &src) {
- static_assert(0 < RADIX && RADIX <= 36, "Radix must be in the range 1..36");
+ static_assert(1 <= RADIX && RADIX <= 36, "Radix must be in the range 2..36");
Review Comment:
should be 1 < RADIX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]