bneradt commented on PR #10970: URL: https://github.com/apache/trafficserver/pull/10970#issuecomment-1879486579
> I don't mind having this script as long as I'm not required to use it, You're definitely not required to use it. I was asked to write this to make it easier for people to get the latest version of cmake. > I wonder why the script uses Homebrew for MacOS where the repository has binaries for MacOS as well. The script wouldn't have the install path limitation if it consistently grab an official release from the GitHub repository. Right, MacOS is a bit more challenging than the Linux case. I'm open to suggestions, but I don't think that using the `.dmg`/`.app` version avoids the install path problem. I don't think that a `.app` file can just be copied anywhere. At least generally speaking they seem to need to go into the `/Applications` directory, or maybe the `~/Applications` directory. And that's initially how I was writing this, but I didn't feel comfortable with this script installing stuff in there. That seemed a bit invasive for an ATS tools script to install stuff into those directories. `brew` on the other hand is a much easier solution. It's just a single command rather than a wget, dmg mount, and copy. `brew` exists after all to make stuff like this easy. Also, `brew` is pretty good about keeping up with the latest version. They already install 3.28.1, which is latest, for instance. Anyway, that's why I chose the `brew` route. That being the case, maybe this script should just not handle MacOS? It can just echo a statement saying "This script does not handle MacOS. Consider the Kitware .dmg file <here> or using brew to install cmake". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
