bneradt commented on code in PR #10952:
URL: https://github.com/apache/trafficserver/pull/10952#discussion_r1445484743
##########
include/iocore/cache/Store.h:
##########
@@ -189,25 +141,23 @@ struct Store {
void
extend(unsigned i)
{
- if (i > n_disks) {
- disk = (Span **)ats_realloc(disk, i * sizeof(Span *));
- for (unsigned j = n_disks; j < i; j++) {
- disk[j] = nullptr;
+ if (i > n_spans) {
+ spans = static_cast<Span **>(ats_realloc(spans, i * sizeof(Span *)));
+ for (unsigned j = n_spans; j < i; j++) {
+ spans[j] = nullptr;
}
- n_disks = i;
+ n_spans = i;
}
}
void delete_all();
- Store();
+ Store(){};
Review Comment:
Suggest: `Store() = default;`
But not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
