JosiahWI opened a new pull request, #10987: URL: https://github.com/apache/trafficserver/pull/10987
This breaks up some of `handleRead` into smaller methods and moves the logic for copying out of the aggregate write buffer to the classes responsible for that buffer. There was a check to make sure that data was only copied from the aggregate write buffer if the requested data was available. I left the old check, and I also duplicated it in `Stripe::copy_from_aggregate_write_buffer` for safety. I thought it would be better to have it in and take it out if it negatively impacts performance than not to have it and find out it would have been useful. I have not benchmarked this. The order of the parameters of `Stripe::copy_from_aggregate_write_buffer` and `AggregateWriteBuffer::copy_from` was chosen to reflect the order of the `memcpy` parameters. This does not mean I like the way `memcpy` chose to do it, I just thought it might help consistency. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
