JosiahWI opened a new pull request, #10991: URL: https://github.com/apache/trafficserver/pull/10991
The global `cache_config_agg_write_backlog` is defined as `2 * AGG_SIZE`. There was an extra `+ AGG_SIZE` in `add_writer` with no comment; this goes back all the way to the original first GitHub commit. This could be a quick hack someone put in to fix an issue. If we need to keep this, I'd like to add a comment explaining why, because it clearly violates the intent of `cache_config_agg_write_backlog`. There is another place in the code where `cache_config_agg_write_backlog` is used, in `Stripe::open_write`, and in that place there is no extra `+ AGG_SIZE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
