ywkaras commented on code in PR #10958:
URL: https://github.com/apache/trafficserver/pull/10958#discussion_r1504972153
##########
src/iocore/net/SSLConfig.cc:
##########
@@ -542,7 +544,13 @@ SSLConfigParams::initialize()
// can cause HTTP layer to connect using SSL. But only if SSL
// initialization hasn't failed already.
client_ctx = this->getCTX(this->clientCertPath, this->clientKeyPath,
this->clientCACertFilename, this->clientCACertPath);
- if (!client_ctx) {
+ if (client_ctx) {
+ return;
+ }
+ // Can't get SSL client context.
+ if (this->clientCertExitOnLoadError) {
+ Fatal("Can't initialize the SSL client, HTTPS in remap rules will not
function");
Review Comment:
I think this should be Emergency(), not Fatal(). Emergency prevents
immediate restart, which won't work if the error is a misconfiguration error:
https://docs.trafficserver.apache.org/developer-guide/api/functions/TSDebug.en.html#c.TSEmergency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
