shukitchan commented on PR #11287: URL: https://github.com/apache/trafficserver/pull/11287#issuecomment-2082079829
@maskit I double checked and i think it should be the fix we should do. If we start from the beginning and insert an oversized entry, _make_space() will always look at the tail entry. So memset to 0 will make we fail gracefully. That's the problem the fuzz test is having. If we already have entries and now add an oversized entry, we need _make_space() to at least clear out all entries first before giving up. So we can't have a precondition check for an oversized entry. That is implied in the unit test - https://github.com/apache/trafficserver/blob/master/src/proxy/hdrs/unit_tests/test_XPACK.cc#L318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
