maskit commented on code in PR #11317:
URL: https://github.com/apache/trafficserver/pull/11317#discussion_r1589681936
##########
src/iocore/net/QUICNetVConnection.cc:
##########
@@ -502,10 +511,8 @@ QUICNetVConnection::is_handshake_completed() const
void
QUICNetVConnection::net_read_io(NetHandler *nh, EThread *lthread)
{
- if (quiche_conn_is_readable(this->_quiche_con)) {
- SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
- this->handleEvent(QUIC_EVENT_PACKET_READ_READY, nullptr);
- }
+ SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
+ this->handleEvent(QUIC_EVENT_PACKET_READ_READY, nullptr);
Review Comment:
Checking `quiche_conn_is_readable` was wrong because the function checks
whether there are readable *streams*. There may be something need to be
processed on the connection level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
